Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

followup aggrid state opti #1125

Merged
merged 4 commits into from
Dec 5, 2024
Merged

followup aggrid state opti #1125

merged 4 commits into from
Dec 5, 2024
+20 −13

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Dec 4, 2024

No description provided.

picklelo
picklelo reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we split it up so that the code they see still has it in the default, but underlying we load it on load? I don't want to make the examples more complex just for our performance

@Alek99
Copy link
Member

Alek99 commented Dec 4, 2024

I'm going to approve for now we can follow up with this

@Alek99 Alek99 self-requested a review December 5, 2024 05:39
@Alek99 Alek99 merged commit 2bb5864 into main Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo left review comments

@Alek99 Alek99 Alek99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lendemor @Alek99 @picklelo